Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactivity API: Add comments to the deepMerge() function #66220

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

michalczaplinski
Copy link
Contributor

What?

I've added comments to the deepMerge() function in the Interactivity API because to make it somewhat easier to follow.

Testing Instructions for Keyboard

There is nothing to test as this change purely adds comments.

@michalczaplinski michalczaplinski added [Type] Code Quality Issues or PRs that relate to code quality [Feature] Interactivity API API to add frontend interactivity to blocks. [Packages] Interactivity /packages/interactivity labels Oct 17, 2024
@michalczaplinski michalczaplinski removed the request for review from luisherranz October 17, 2024 18:16
Copy link
Contributor

@DAreRodz DAreRodz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: michalczaplinski <czapla@git.wordpress.org>
Co-authored-by: DAreRodz <darerodz@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Base automatically changed from fix/iapi-deep-merge-undefined-objects-reactivity to trunk October 18, 2024 10:54
@DAreRodz DAreRodz force-pushed the update/add-comments-deep-merge branch from 71b2a14 to ad8b101 Compare October 18, 2024 15:16
@DAreRodz
Copy link
Contributor

I had to fix the branch by force-pushing the commits that only belonged to this PR. My bad. 🙈

@DAreRodz DAreRodz enabled auto-merge (squash) October 18, 2024 15:37
@DAreRodz DAreRodz merged commit 0ae2cb8 into trunk Oct 18, 2024
62 checks passed
@DAreRodz DAreRodz deleted the update/add-comments-deep-merge branch October 18, 2024 15:53
@github-actions github-actions bot added this to the Gutenberg 19.6 milestone Oct 18, 2024
@cbravobernal cbravobernal changed the title iAPI: Add comments to the deepMerge() function Interactivity API: Add comments to the deepMerge() function Nov 6, 2024
karthick-murugan pushed a commit to karthick-murugan/gutenberg that referenced this pull request Nov 13, 2024
* update comment

* Add comments

Co-authored-by: michalczaplinski <czapla@git.wordpress.org>
Co-authored-by: DAreRodz <darerodz@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Interactivity API API to add frontend interactivity to blocks. [Packages] Interactivity /packages/interactivity [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants