-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move embed API call out of block and into data #6678
Merged
notnownikki
merged 15 commits into
master
from
update/embed-preview-fetched-with-data-api
Aug 7, 2018
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
1c5090e
Move embed API call out of block and into data
notnownikki a78196b
Update for apiFetch
notnownikki c9d9bc5
fix tests
notnownikki e2f4f0a
Move the edit component out of settings for easier testing
notnownikki 14b7e75
Reinstate edit controls
notnownikki 49ef894
Merge branch 'master' into update/embed-preview-fetched-with-data-api
notnownikki 3db8a04
switch to `addQueryArgs`
notnownikki 796bf22
Get rid of a lot of the embed edit component's state
notnownikki 320a2ec
Merge remote-tracking branch 'origin/master' into update/embed-previe…
notnownikki 741b2af
Fixed editing url state
notnownikki 5b456c4
Merge remote-tracking branch 'origin/master' into update/embed-previe…
notnownikki 35db192
Fix previous merge mess-up
notnownikki 1a451d8
Trying to make fetching happen
notnownikki ad831ec
Fix isResolving core data selector
youknowriad 142d263
Split `processPreview` into methods with distinct responsibilities
notnownikki File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems fragile to test the
html
. WP can decide to change the fallback right? Can't we add an explicit attribute to the embed endpoint when it's a fallback:isFallback: true
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The embed fallbacks are currently done by a filter in
embed_maybe_make_link
, and that only deals with HTML, you can't change any of the data structure. We'd have to change the core embed code itself to do that.