Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add consistant illustrator to file block #66839

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

up1512001
Copy link
Member

What?

Added consistent illustrator for File block similar to the image block.

Why?

Part of #66828

How?

  • added Placeholder into MediaPlaceholder similar to image block.

Testing Instructions

  1. open the editor and insert the File block & Image block
  2. select on File block and dis-select it see illustrator similar to the Image block

Screenshots or screencast

Screen.Recording.2024-11-08.at.00.08.00.mov

@up1512001 up1512001 added [Type] Copy Issues or PRs that need copy editing assistance [Block] File Affects the File Block labels Nov 7, 2024
@up1512001 up1512001 self-assigned this Nov 7, 2024
@up1512001 up1512001 requested a review from ajitbohra as a code owner November 7, 2024 18:39
Copy link

github-actions bot commented Nov 7, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: up1512001 <up1512001@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an issue that needs to be addressed before this PR can proceed, see #66838 (comment).

image

@up1512001 up1512001 added [Type] Enhancement A suggestion for improvement. and removed [Type] Copy Issues or PRs that need copy editing assistance labels Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] File Affects the File Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants