Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance; Stop unnecessary rerenders caused by withColors #6686

Merged
merged 1 commit into from
May 11, 2018
Merged

Improve performance; Stop unnecessary rerenders caused by withColors #6686

merged 1 commit into from
May 11, 2018

Commits on May 11, 2018

  1. Improve performance of withColors, stop unnecessary rerenders. 

    The getColor and setColor functions returned a new object or a new function every time, although the code looked correct it made unnecessary rerenders happen. We now returned memoized functions this ensure that if the parameters are not changed we will return references for the same object or function so no rerender happen.
    @jorgefilipecosta
    jorgefilipecosta committed May 11, 2018
    Configuration menu
    Copy the full SHA
    56a11cb View commit details
    Browse the repository at this point in the history