Fix: Accessibility issue with links listing blocks. #(64051)

docs/reference-guides/core-blocks.md

@@ -912,8 +912,8 @@ A cloud of popular keywords, each sized by how often it appears. ([Source](https
 
 -	**Name:** core/tag-cloud
 -	**Category:** widgets
--	**Supports:** align, interactivity (clientNavigation), spacing (margin, padding), typography (lineHeight), ~~html~~
--	**Attributes:** largestFontSize, numberOfTags, showTagCounts, smallestFontSize, taxonomy
+-	**Supports:** align, ariaLabel, interactivity (clientNavigation), spacing (margin, padding), typography (lineHeight), ~~html~~
+-	**Attributes:** ariaLabel, largestFontSize, numberOfTags, showTagCounts, smallestFontSize, taxonomy
 
 ## Template Part
 

packages/block-library/src/categories/edit.js

@@ -167,7 +167,7 @@ export default function CategoriesEdit( {
 
 	const TagName =
 		!! categories?.length && ! displayAsDropdown && ! isResolving
-			? 'ul'
+			? 'nav'
 			: 'div';
 
 	const classes = clsx( className, {
@@ -257,9 +257,11 @@ export default function CategoriesEdit( {
 			) }
 			{ ! isResolving &&
 				categories?.length > 0 &&
-				( displayAsDropdown
-					? renderCategoryDropdown()
-					: renderCategoryList() ) }
+				( displayAsDropdown ? (
+					renderCategoryDropdown()
+				) : (
+					<ul>{ renderCategoryList() }</ul>
+				) ) }
 		</TagName>
 	);
 }

packages/block-library/src/categories/index.php

@@ -66,7 +66,7 @@ function render_block_core_categories( $attributes, $content, $block ) {
 	} else {
 		$args['show_option_none'] = $taxonomy->labels->no_terms;
 
-		$wrapper_markup = '<ul %1$s>%2$s</ul>';
+		$wrapper_markup = '<nav %1$s><ul>%2$s</ul></nav>';
 		$items_markup   = wp_list_categories( $args );
 		$type           = 'list';
 

packages/block-library/src/tag-cloud/block.json

@@ -28,6 +28,10 @@
 		"largestFontSize": {
 			"type": "string",
 			"default": "22pt"
+		},
+		"ariaLabel": {
+			"type": "string",
+			"default": "Tag Cloud"
 		}
 	},
 	"styles": [
@@ -52,6 +56,7 @@
 		"interactivity": {
 			"clientNavigation": true
 		},
+		"ariaLabel": true,
 		"__experimentalBorder": {
 			"radius": true,
 			"color": true,

packages/block-library/src/tag-cloud/edit.js

@@ -13,6 +13,7 @@ import {
 	__experimentalParseQuantityAndUnitFromRawValue as parseQuantityAndUnitFromRawValue,
 	__experimentalVStack as VStack,
 	Disabled,
+	TextControl,
 } from '@wordpress/components';
 import { useSelect } from '@wordpress/data';
 import { __ } from '@wordpress/i18n';
@@ -48,6 +49,7 @@ function TagCloudEdit( { attributes, setAttributes } ) {
 		numberOfTags,
 		smallestFontSize,
 		largestFontSize,
+		ariaLabel,
 	} = attributes;
 
 	const [ availableUnits ] = useSettings( 'spacing.units' );
@@ -107,6 +109,10 @@ function TagCloudEdit( { attributes, setAttributes } ) {
 		setAttributes( updateObj );
 	};
 
+	const onChangeAriaLabel = ( value ) => {
+		setAttributes( { ariaLabel: value } );
+	};
+
 	// Remove border styles from the server-side attributes to prevent duplicate border.
 	const serverSideAttributes = {
 		...attributes,
@@ -117,79 +123,92 @@ function TagCloudEdit( { attributes, setAttributes } ) {
 	};
 
 	const inspectorControls = (
-		<InspectorControls>
-			<PanelBody title={ __( 'Settings' ) }>
-				<VStack
-					spacing={ 4 }
-					className="wp-block-tag-cloud__inspector-settings"
-				>
-					<SelectControl
-						__nextHasNoMarginBottom
-						__next40pxDefaultSize
-						label={ __( 'Taxonomy' ) }
-						options={ getTaxonomyOptions() }
-						value={ taxonomy }
-						onChange={ ( selectedTaxonomy ) =>
-							setAttributes( { taxonomy: selectedTaxonomy } )
-						}
-					/>
-					<Flex gap={ 4 }>
-						<FlexItem isBlock>
-							<UnitControl
-								label={ __( 'Smallest size' ) }
-								value={ smallestFontSize }
-								onChange={ ( value ) => {
-									onFontSizeChange(
-										'smallestFontSize',
-										value
-									);
-								} }
-								units={ units }
-								min={ MIN_FONT_SIZE }
-								max={ MAX_FONT_SIZE }
-								size="__unstable-large"
-							/>
-						</FlexItem>
-						<FlexItem isBlock>
-							<UnitControl
-								label={ __( 'Largest size' ) }
-								value={ largestFontSize }
-								onChange={ ( value ) => {
-									onFontSizeChange(
-										'largestFontSize',
-										value
-									);
-								} }
-								units={ units }
-								min={ MIN_FONT_SIZE }
-								max={ MAX_FONT_SIZE }
-								size="__unstable-large"
-							/>
-						</FlexItem>
-					</Flex>
-					<RangeControl
-						__nextHasNoMarginBottom
-						__next40pxDefaultSize
-						label={ __( 'Number of tags' ) }
-						value={ numberOfTags }
-						onChange={ ( value ) =>
-							setAttributes( { numberOfTags: value } )
-						}
-						min={ MIN_TAGS }
-						max={ MAX_TAGS }
-						required
-					/>
-					<ToggleControl
-						__nextHasNoMarginBottom
-						label={ __( 'Show tag counts' ) }
-						checked={ showTagCounts }
-						onChange={ () =>
-							setAttributes( { showTagCounts: ! showTagCounts } )
-						}
-					/>
-				</VStack>
-			</PanelBody>
-		</InspectorControls>
+		<>
+			<InspectorControls>
+				<PanelBody title={ __( 'Settings' ) }>
+					<VStack
+						spacing={ 4 }
+						className="wp-block-tag-cloud__inspector-settings"
+					>
+						<SelectControl
+							__nextHasNoMarginBottom
+							__next40pxDefaultSize
+							label={ __( 'Taxonomy' ) }
+							options={ getTaxonomyOptions() }
+							value={ taxonomy }
+							onChange={ ( selectedTaxonomy ) =>
+								setAttributes( { taxonomy: selectedTaxonomy } )
+							}
+						/>
+						<Flex gap={ 4 }>
+							<FlexItem isBlock>
+								<UnitControl
+									label={ __( 'Smallest size' ) }
+									value={ smallestFontSize }
+									onChange={ ( value ) => {
+										onFontSizeChange(
+											'smallestFontSize',
+											value
+										);
+									} }
+									units={ units }
+									min={ MIN_FONT_SIZE }
+									max={ MAX_FONT_SIZE }
+									size="__unstable-large"
+								/>
+							</FlexItem>
+							<FlexItem isBlock>
+								<UnitControl
+									label={ __( 'Largest size' ) }
+									value={ largestFontSize }
+									onChange={ ( value ) => {
+										onFontSizeChange(
+											'largestFontSize',
+											value
+										);
+									} }
+									units={ units }
+									min={ MIN_FONT_SIZE }
+									max={ MAX_FONT_SIZE }
+									size="__unstable-large"
+								/>
+							</FlexItem>
+						</Flex>
+						<RangeControl
+							__nextHasNoMarginBottom
+							__next40pxDefaultSize
+							label={ __( 'Number of tags' ) }
+							value={ numberOfTags }
+							onChange={ ( value ) =>
+								setAttributes( { numberOfTags: value } )
+							}
+							min={ MIN_TAGS }
+							max={ MAX_TAGS }
+							required
+						/>
+						<ToggleControl
+							__nextHasNoMarginBottom
+							label={ __( 'Show tag counts' ) }
+							checked={ showTagCounts }
+							onChange={ () =>
+								setAttributes( {
+									showTagCounts: ! showTagCounts,
+								} )
+							}
+						/>
+					</VStack>
+				</PanelBody>
+			</InspectorControls>
+			<InspectorControls group="advanced">
+				<TextControl
+					__next40pxDefaultSize
+					__nextHasNoMarginBottom
+					label={ __( 'Tag Cloud Name' ) }
+					value={ ariaLabel }
+					onChange={ onChangeAriaLabel }
+				/>
+			</InspectorControls>
+		</>
 	);
 
 	return (

packages/block-library/src/tag-cloud/index.php

@@ -17,6 +17,7 @@
 function render_block_core_tag_cloud( $attributes ) {
 	$smallest_font_size = $attributes['smallestFontSize'];
 	$unit               = ( preg_match( '/^[0-9.]+(?P<unit>[a-z%]+)$/i', $smallest_font_size, $m ) ? $m['unit'] : 'pt' );
+	$aria_label         = isset( $attributes['ariaLabel'] ) ? $attributes['ariaLabel'] : 'Tag Cloud';
 
 	$args      = array(
 		'echo'       => false,
@@ -40,9 +41,12 @@ function render_block_core_tag_cloud( $attributes ) {
 
 	$wrapper_attributes = get_block_wrapper_attributes();
 
+	$aria_label_attribute = 'aria-label="' . esc_attr( $aria_label ) . '" ';
+
 	return sprintf(
-		'<p %1$s>%2$s</p>',
+		'<nav %1$s %2$s>%3$s</nav>',
 		$wrapper_attributes,
+		$aria_label_attribute,
 		$tag_cloud
 	);
 }