-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block Style Variations: Fix complex variation selectors when using selectors API #67061
Block Style Variations: Fix complex variation selectors when using selectors API #67061
Conversation
Flaky tests detected in 9d0147e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11904578790
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the instructions and unit tests. 🚢
Fixes: #66885
What?
Fixes a bug in the manipulation of selectors for block style variations that would result in an incorrect selector and fail to match the appropriate elements on the frontend.
Why?
How?
Tweaks how the original block name in the block's selector is replaced so that it doesn't miss more complex selectors e.g. ones with compound classes, CSS functions etc.
Testing Instructions
npm run test:unit:php:base -- --filter WP_Theme_JSON_Gutenberg_Test
__experimentalSelector
property in block.jsonThere might be more use cases I'm missing so bonus points for testing more than the list above 😅
Screenshots or screencast
Note the missing border in the
Before
image above.