Make Write mode and Zoom out block options menus consistent #67749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -48 B (0%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
draganescu
force-pushed
the
fix/zoom-out-write-mode-block-options
branch
2 times, most recently
from
8d86348 to
cad44fd
Compare
draganescu
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
talldan
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
This is a good improvement over trunk.
I think it'd be good to consider adding e2e tests for this kind of change as it's very specific behavior, and regressions are hard to spot. I don't think it has to be complicated, probably just some simple assertions that sections in content only and zoom out show the right settings menu options, and paragraphs don't have a settings menu.
I did manually test the settings menu in different scenarios that utilize content only:
- Write Mode works as expected
- Zoom Out works as expected
- Page Editing / Synced Patterns / Template Locking don't show any regressions
As an aside, I still notice some unusual behaviors that might be good to follow up on, but I don't think they were introduced by this PR, they're also present in trunk:
Button blocks have a settings menu
Most content blocks don't have a settings menu in write mode:
But for some reason the button block does have one, with just the copy option:
List Item blocks have a settings menu and can be inserted/removed
I'm not sure this is on purpose or not, but list items also have a settings menu:
They can also be inserted/removed in Write Mode. They can be indented, but not un-indented. I have no idea what's going on here!
packages/block-editor/src/components/block-settings-menu/block-settings-dropdown.js
Outdated
Show resolved
Hide resolved
draganescu
force-pushed
the
fix/zoom-out-write-mode-block-options
branch
from
cad44fd to
70e6f12
Compare
|
Flaky tests detected in ce7cc5b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12296477618
|
yogeshbhutkar
pushed a commit
to yogeshbhutkar/gutenberg
that referenced
this pull request
Dec 18, 2024
…s#67749) * hide block settings slot in content only and zoom out, allow copy in content only * adds tests for counting the length of the options menu * remove duplicate condition, zoom out makes sections content only Co-authored-by: draganescu <andraganescu@git.wordpress.org> Co-authored-by: talldan <talldanwp@git.wordpress.org> Co-authored-by: rinkalpagdar <rinkalpagdar@git.wordpress.org> Co-authored-by: richtabor <richtabor@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #67658
Why?
To ensure consistency, the menu in write mode should be updated to match the zoom out menu, which includes options for “Copy,” “Duplicate,” and “Delete.”
How?
Testing Instructions
Testing Instructions for Keyboard
N/A
Screenshots or screencast
consistent-block-options.mp4