Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button Block: Refactor setting panel #67887

Conversation

Mayank-Tripathi32
Copy link
Contributor

part of #67813

Before

|image

After

|image

image

@Mayank-Tripathi32 Mayank-Tripathi32 changed the title Button: Refactor "Settings" panel of Button block to use ToolsPanel instead of PanelBody Button Block: Refactor setting panel Dec 12, 2024
@Mayank-Tripathi32 Mayank-Tripathi32 marked this pull request as ready for review December 12, 2024 19:01
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Mayank-Tripathi32 <mayanktripathi32@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@fabiankaegy fabiankaegy added [Type] Enhancement A suggestion for improvement. [Block] Buttons Affects the Buttons Block labels Dec 12, 2024
Copy link
Member

@fabiankaegy fabiankaegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as expected :) Thanks so much for your contribution! 🎉

CleanShot.2024-12-12.at.20.19.30.mp4

@fabiankaegy fabiankaegy merged commit 51e124c into WordPress:trunk Dec 12, 2024
72 of 74 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.0 milestone Dec 12, 2024
yogeshbhutkar pushed a commit to yogeshbhutkar/gutenberg that referenced this pull request Dec 18, 2024
…f PanelBody (WordPress#67887)

Co-authored-by: Mayank-Tripathi32 <mayanktripathi32@git.wordpress.org>
Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Buttons Affects the Buttons Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor "Settings" panel of Button block to use ToolsPanel instead of PanelBody
2 participants