Social Links: Fix appender size in non-iframe editor #68215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +40 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 5975307. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12443370901
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up #65769
What?
#65769 made the appender size of the Social Icons block equal to the actual icons. However, I found that this size was incorrect in the non-iframe editor and the widget editor:
Why?
The appender button is expected to be
1.5emsized, inheriting the font size applied to the Social Icons block.However, it is not variable-sized because the 13px font size is always applied by the
.block-editor-inserter selector. Because this style comes from the block editor, it will not be loaded in the iframe editor, but non-iframe editors will be affected by this style:How?
Add
font-size: inheritto inherit the font size of the Social Icons block.Testing Instructions
useShouldIframe()hook conditions are met.Screenshots or screencast
2d897d7c294c801c687baf650a805a8d.mp4