Converts tests for FormTokenField to use React.TestUtils #7777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since this test is simulating events on rendered elements into a DOM, this required the use of React.TestUtils over react-test-renderer. The neat thing here is this also shaved close to a second off of the execution time for this test.
nerrad
added
the
[Type] Automated Testing
aduth
deleted the
update/convert-enzyme-tests-to-use-test-utils-form-token-field.js
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This converts the tests for
components/form-token-field/test/index.jsfromenzymetoReact.TestUtils. This is because enzyme does not support React 16.3+ (and movement to do so is really slow). This will fix issues with breakage due to the enzyme incompatibility as components receive React 16.3+ features (such as forwardRef usage in #7557)Since this test is simulating events on rendered elements into a DOM, this required the use of React.TestUtils over react-test-renderer.
The neat thing here is this also shaved close to a second off of the execution time for this test (Note: very rudimentary comparison of the average between 3 runs without these changes and 3 runs after these changes)
Checklist: