Switch tests away from using enzyme.mount (components/higher-order/with-focus-outside/test/index.js) #7827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This switches all tests in `components/higher-order/with-focus-outside/test/index.js` from using enzyme.shallow and enzyme.mount to `React.TestUtils`. This is because `enzyme` does not fully support React 16.3+ (and movement to do so is really slow). This will fix issues with breakage due to the enzyme incompatibility as components receive React 16.3+ features (such as `forwardRef` usage in #7557).
nerrad
added
[Type] Automated Testing
gziolo
reviewed
Jul 12, 2018
| @@ -12,9 +12,12 @@ import { Component } from '@wordpress/element'; | |||
| * Internal dependencies | |||
| */ | |||
| import withFocusOutside from '../'; | |||
| import ReactDOM from 'react-dom'; | |||
|
|
|||
| jest.useFakeTimers(); | |||
There was a problem hiding this comment.
Aside: we have fake timers enabled by default ...
There was a problem hiding this comment.
That was already in this test, so likely can just be an additional improvement to the original test?
There was a problem hiding this comment.
If you can remove at the same time, it would be awesome. It should work 😓
There was a problem hiding this comment.
ya looks like tests pass fine with it removed.
| return <TestComponent />; | ||
| }; | ||
|
|
||
| const simulateEvent = ( event, position = 0 ) => { |
There was a problem hiding this comment.
position is confusing in this context. I assumed this is position on the screen at first. Did you mean index?
|
|
||
| jest.useFakeTimers(); | ||
|
|
||
| let wrapper, callback; |
There was a problem hiding this comment.
Can we rename callback to onFocusOutside to make it easier to read since it is now hidden inside beforeEach method?
gziolo
deleted the
update/with-focus-outside.js-replace-usage-of-enzyme.mount-with-React.TestUtils
branch
ellatrix
added
[Type] Code Quality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This switches all tests in
components/higher-order/with-focus-outside/test/index.jsfrom using enzyme.shallow and enzyme.mount toReact.TestUtils. This is becauseenzymedoes not fully support React 16.3+ (and movement to do so is really slow). This will fix issues with breakage due to the enzyme incompatibility as components receive React 16.3+ features (such asforwardRefusage in #7557).Checklist: