Components: Update Dashicon to latest build #7898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
the
[Feature] UI Components
|
It'll be a little while of afk before I can test properly, so if you'd like to get this in sooner, would be good up expand the review range. But purely as a sanity check, this looks good to me 👍👍 |
|
I think we have also a corresponding issue for it, I will try to track it down. |
|
Thanks for the quick fix! I updated the vendored Gutenberg in Automattic/wp-calypso#25590 to the latest version and removed another custom patch from there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3952
Related: WordPress/dashicons#305
Related: Automattic/wp-calypso#25590 (comment) (cc @jsnajdr)
This pull request seeks to incorporate the latest version of the Dashicons React component generated from the
WordPress/dashiconsrepository, which defines the component class using the@wordpress/elementmodule dependency, rather than relying on the presence of awp.element.Componentglobal.Testing instructions:
Verify there are no regressions in the display of icons throughout the application.