Show UI on text selection #861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtias
added
[Feature] Blocks
|
I love how this works. 👍 👍 from me! |
aduth
reviewed
May 23, 2017
|
|
||
| this.setState( { | ||
| empty: ! content || ! content.length, | ||
| } ); | ||
|
|
||
| if ( this.props.focus.collapsed !== collapsed ) { |
There was a problem hiding this comment.
Could we expect focus to ever be undefined at this point?
There was a problem hiding this comment.
If somehow the editor is active and the block is not selected, then yes. Maybe getBlockFocus should return an empty object in that case? Or not? Cc @youknowriad.
There was a problem hiding this comment.
It think this is possible when the editor become active (before the rerender), it's worth checking IMO. good catch @aduth
This was referenced Dec 6, 2022
This was referenced Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #712.