swaps out the CSS2 :before with the CSS3 ::before #8630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisysocks
approved these changes
Aug 7, 2018
There was a problem hiding this comment.
LGTM 👍
Are we able to add a lint rule to catch this? I'm not sure that we have a CSS linter set up. cc. @tofumatt
noisysocks
added
the
[Type] Code Quality
|
The Previously #1151 |
|
Nice. Let's go ahead and get this in then. Is setting up stylelint something you have time to do, @ntwb? If not I can take a crack at it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to address #8618 by swapping
:beforewith::beforein SCSS