Chrome: Adding the post excerpt panel #871
Conversation
youknowriad
added
the
General Interface
|
Hmm, I'm getting some JS errors as soon as I open the sidebar now:
Do I need to npm update? |
|
@jasmussen Oh sorry about this, I was testing with a saved post. It should be ok now. |
|
Love it. 👍 from me. Also 🔥 this is going fast! |
|
Looks good to me too. I think there might be some accessibility concerns, but maybe best to fix in a separate PR. Maybe the area needs a label? |
|
Hm, also seeing this:
|
Also adds an aria-label to the excerpt
editor/sidebar/post-excerpt/index.js
Outdated
| </a> | ||
| </PanelBody> | ||
| ); | ||
| /* eslint-enable jsx-a11y/label-has-for */ |
There was a problem hiding this comment.
Good catch (Ah copy/paste)
editor/sidebar/post-excerpt/index.js
Outdated
| excerpt: getEditedPostExcerpt( state ), | ||
| } ), | ||
| ( dispatch ) => { | ||
| return { |
There was a problem hiding this comment.
Minor: Should we be consistent with how we're creating object return values between mapStateToProps and mapDispatchToProps, i.e. either with an explicit return in both, or implied here:
( dispatch ) => ( {
onUpdateExcerpt( excerpt ) {
dispatch( editPost( { excerpt } ) );
},
} )There was a problem hiding this comment.
Right! do you have a preference. I'm leaning towards the explicit return (less magic) but I'm ok with both
There was a problem hiding this comment.
I don't feel strongly. I personally prefer the compact version, but understand that it can be a bit more difficult to interpret (largely because of the need to wrap parentheses for an implicit object return value).
closes #856