Add new Insert Before/After menu items and shortcuts

[talldan]

Description

Closes #7297

Adds the following keyboard shortcuts for those actions:

• Option+Cmd+T (Mac) / Ctrl+Alt+T - Insert Before
• Option+Cmd+Y (Mac) / Ctrl+Alt+Y - Insert After

How has this been tested?

• Tested use of MenuItem and shortcut across browsers on Mac (Chrome, Safari, Firefox, Opera)
• Tested use of MenuItem and shortcut across browsers on Windows (Chrome, IE11, Edge, Firefox, Opera)
• Tested with a block that uses InnerBlocks with a template lock

Screenshots

MenuItems

Shortcut Help

Types of changes

New feature (non-breaking change which adds functionality)

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code follows the accessibility standards.
• My code has proper inline documentation.

[jasmussen]

Screenshot:

Love it. Works as intended.

Might want a code sanity check by @noisysocks, but otherwise, ship it!

[talldan]

Great - I still need to do a bit of work on the template locking side of things. I'll do that first and then get a code review

[talldan]

Ready for review now :)

[noisysocks]

Code looks fab, and everything works great in my testing!

I tested template locking using this custom post type:

register_post_type( 'test_type', array(
	'label' => 'Test',
	'public' => true,
	'show_in_rest' => true,
	'template_lock' => 'insert',
	'template' => array(
		array( 'core/image' ),
		array( 'core/quote' ),
		array( 'core/image' ),
	),
) );

And this custom block:

registerBlockType( 'test/block', {
	title: 'Test block',
	category: 'common',
	save: () => null,
	edit() {
		return (
			<wp.editor.InnerBlocks
				templateLock="insert"
				template={ [ [ 'core/image' ], [ 'core/image' ] ] }
			/>
		);
	},
} );

Great job 👍👍👌:shipit:

[noisysocks]

Nit: you could put newlines into these function arguments if you don't want props in the scope.

withDispatch( ( dispatch, {
	clientIds,
	rootClientId,
	// etc.
} ) ) {
	// etc.
}

[noisysocks]

Nice, a sneaky bug fix!

[mtias]

Nice one!