Automatically create a link when selected text is a URL #9067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisysocks
added
[Type] Enhancement
packages/url/src/test/index.test.js
Outdated
| ]; | ||
|
|
||
| forEach( urls, ( url ) => { | ||
| expect( isURL( url ) ).toBe( true ); |
There was a problem hiding this comment.
equivalent to: expect( every( urls, isURL ) ).toBe( true );
| * | ||
| * @return {boolean} Whether or not it looks like a URL. | ||
| */ | ||
| export function isURL( url ) { |
There was a problem hiding this comment.
Nice util, I think we may be able to use it in:
Removing a duplicate regex.
There was a problem hiding this comment.
I've already replaced that regex 🙂
There was a problem hiding this comment.
Nice feature 👍
It is working well I think we have a small bug that we should address before the merge. After we add a link using this method if we click right away on the edit button nothing happens the edit button does not work. If we select other block and then come back and press edit things work well.
|
Good catch @jorgefilipecosta! I've fixed this in 50c9c01. |
noisysocks
force-pushed
the
fix/disappearing-link-selection
branch
from
543da2f to
47d0bd8
Compare
noisysocks
force-pushed
the
add/auto-link-selected-urls
branch
2 times, most recently
from
0f90d62 to
beee381
Compare
noisysocks
changed the base branch from
fix/disappearing-link-selection
to
master
jorgefilipecosta
approved these changes
Aug 21, 2018
When a URL is selected and the Link button is clicked or the Link keyboard shortcut is pressed, a link with that URL set as its href should be instantly created.
Fixes a bug that prevented the user from selecting a link which has text that looks like a URL and clicking Edit. We accomplish this by distinguishing between editing a link (isEditingLink) and adding a new link (isAddingLink).
noisysocks
force-pushed
the
add/auto-link-selected-urls
branch
from
beee381 to
79f19e2
Compare
|
Thanks for this improvement! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3513.
When a URL is selected and the Link button is clicked or the Link keyboard shortcut is pressed, a link with that URL set as its
hrefshould be instantly created.As part of this, I pulled an existing link regular expression out into its own
isURLfunction that lives in the@wordpress/urlpackage. Not sure if it's actually a useful helper function, though—happy to go back on this decision.To test:
Or, for those of us who distrust automation: