Babel Makepot: Translator comments have been extracted from the file

[akirk]

Description

In the POT file generated by Gutenberg the translator comments are extracted into regular comments (denoted with just a #) while they should be denoted with a #.

This is a mixup on the term "translator" comments. As can be seen in section "2.2.1 Extracted Comments" of The PO Format, the comments denoted with translators: are actually called "extracted comments" in the PO file format.

How has this been tested?

1. Run npm run build to create the POT file in languages/gutenberg.pot
2. Run npx pot-to-php ./languages/gutenberg.pot ./languages/gutenberg-translations.php gutenberg to generate the PHP file

Types of changes

Janitorial

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code follows the accessibility standards.
• My code has proper inline documentation.

[akirk]

See also https://www.gnu.org/software/gettext/manual/html_node/PO-Files.html

Comment lines starting with #. contain comments given by the programmer, directed at the translator; these comments are called extracted comments because the xgettext program extracts them from the program’s source code.

[gziolo]

@swissspidy what's the future of @wordpress/babel-plugin-makepot? Does it make sense to land these changes proposed?

[aduth]

Confusing indeed. For reference, the treatment of the extracted property occurs in gettext-parser here:

https://github.com/smhg/gettext-parser/blob/4377b96dcceef94fecac8d17bb9644d66adf8f91/lib/pocompiler.js#L64-L79

I'll defer to you two on this one, and the referenced documentation seems to reaffirm the correction.

I've force-pushed a rebased copy of the branch to be able to add a CHANGELOG entry as a fix.

I contemplated whether to consider the module.exports.getTranslatorComment removal as a breaking change, but in usage as a Babel plugin it has no effect. Those exports are used exclusively for the unit tests.