-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the error page design to include information about the error #2586
Comments
Discussion relating to this issue here: |
I'm copying the request for updates to the No results error page from the closed issue #511 here:
|
I have a few ideas for this, but before, I would love some guidance on the following:
I don't follow this error. Can you elaborate more? In ticket #2612, is suggested to "show the media type and the id." So my main questions are:
If this doesn't relate to a single content, then, showing a message on the search results sounds more in context. Am I understanding it correctly?
Is this related to a single content or to the whole search result? If it's the first, then landing on a page asking you to refresh it sounds sufficient. Am I correct? For the special cases
From this I deduct three layouts and use cases: all content, image, and audio results. Am I correct?
Can someone elaborate on how this works and what users need to do to continue searching?
To me, a message replacing the whole related media area seems clear enough. Pinging @obulat as Zack is AFK. But any opinion and suggestion is truly welcome. |
We should delay the implementation of these changes until after we convert to Nuxt 3 because it has a nice related feature, 404 for single media result pages with non-existent id
429 for throttled requests
Some users try to scrape the frontend, and they get throttled after they get the search results. So, they attempt to automatically click on the results - but get the 429 error for each single result they try to open. 500 for API internal server error
This can happen both for the search results and the single item. I think showing a page asking you to refresh would be sufficient. For the special casesFor All content view: what should be done when only one of the media types received an error?
I think we already have an error page when the image search results page or the audio search results page fail to load. What I meant here is when the user is on All content search results page, and, for example, image results load, but the audio results fail. So, the user was expecting to see the mixed results, but sees only the images. This might be fixed by reloading or maybe by clicking on the Load more button, which attempts to re-fetch the first page of audio. Errors on the "Load more" fetching?
If there was a network error, or a timeout error (so, an error that can be fixed by retrying fetching) when the user clicked on Load more button, they will not see the additional results. They will need to click the load more button again. Should we display an error when there is an error loading Related media, or just hide the section?
|
Description
Kinds of errors
404 for pages that do not exist (openverse.org/nonexistentpage)
404 for single media result pages with non-existent
id
429 for throttled requests - #2586
500 for API internal server error (can be the same as no. 1?)
Timeout errors
Special cases
What should we show for the following client-side errors:
When the requests fail with 429, the user should see an error page with a message indicating what the user can do and when they can resume using Openverse.
Sentry issue
Sentry Issue: OPENVERSE-FRONTEND-ZP
Note: This issue originally only said "Add 429 error page", but was edited to include more error kinds
The text was updated successfully, but these errors were encountered: