-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add links to additional views to sources table #3749
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great and runs as expected locally!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR LGTM locally, but I think we should at least add an e2e test that confirms the behaviour when the feature flag is on. I don't see why we should wait to add the functionality test, at least.
1e4ebc3
to
5192040
Compare
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
5192040
to
d87673a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just leaving a suggested change that I think will fix the new test to pass. Thanks for adding it!
}) | ||
await page.goto("/sources") | ||
await page.getByRole("link", { name: "Animal Diversity Web" }).click() | ||
await page.waitForURL("/source/animal-diversity-web") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test is failing, but I think this would fix it 🤔
await page.waitForURL("/source/animal-diversity-web") | |
await page.waitForURL("/images/source/animal-diversity-web") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Arrrghh! Thank you for catching this!
Oh, and we also need to add the tape.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ended up replacing Animal Diversity Web with Flickr, so that I don't need to add any more tapes.
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Based on the medium urgency of this PR, the following reviewers are being gently reminded to review this PR: @dhruvkb Excluding weekend1 days, this PR was ready for review 4 day(s) ago. PRs labelled with medium urgency are expected to be reviewed within 4 weekday(s)2. @obulat, if this PR is not ready for a review, please draft it to prevent reviewers from getting further unnecessary pings. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes
Fixes #3578 by @AetherUnbound
Description
This PR adds the source view links to the names in the table on the
/sources
page.Testing Instructions
Make sure that the deployment env is not set to production in your
frontend/.env
file, otherwise the flag will not switchRun the app
Go to
/preferences
page and switch theadditional_search_views
on.Go to
/sources
page and check that the links work and open thesource
view.I did not update the snapshots because this feature is under flag. I think it's best to update them after the flag is turned on in staging.
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin