Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit Test: Ensure that apply_filters is extracted, and that the parameters to it are as well. #241

Merged
merged 2 commits into from
Jan 19, 2024
Merged

Unit Test: Ensure that apply_filters is extracted, and that the parameters to it are as well. #241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c1bf8d
Add a apply_filters() unit test.
dd32 Jan 17, 2024
93eeddb
Add a way to test that the arguments are extracted.
dd32 Jan 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion tests/phpunit/includes/export-testcase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,13 @@ protected function assertEntityContains( $entity, $type, $expected ) {
foreach ( $entity[ $type ] as $exported ) {
if ( $exported['line'] == $expected['line'] ) {
foreach ( $expected as $key => $expected_value ) {
$this->assertEquals( $expected_value, $exported[ $key ] );
if ( isset( $exported[ $key ] ) ) {
$exported_value = $exported[ $key ];
} else {
$exported_value = _wp_array_get( $exported, explode( '.', $key ), null );
}

$this->assertEquals( $expected_value, $exported_value );
}

return;
Expand Down
1 change: 1 addition & 0 deletions tests/phpunit/tests/export/hooks.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,4 @@ do_action( "action_with_double_quotes" );
do_action( $variable . '-action' );
do_action( "another-{$variable}-action" );
do_action( 'hook_' . $object->property . '_pre' );
apply_filters( 'plain_filter', $variable, $filter_context );
10 changes: 10 additions & 0 deletions tests/phpunit/tests/export/hooks.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,5 +35,15 @@ public function test_hook_names_standardized() {
$this->assertFileContainsHook(
array( 'name' => 'hook_{$object->property}_pre', 'line' => 7 )
);

$this->assertFileContainsHook(
array(
'type' => 'filter',
'name' => 'plain_filter',
'line' => 8,
'arguments.0' => '$variable',
'arguments.1' => '$filter_context'
)
);
}
}