VS Code and wp-now: Allow the login() step to fail #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The user may customize their login details. Changing the password should not prevent them from starting the server again. This PR adds tolerance for login() failures. 1. Start a wp-now site 1. Change the admin password 1. Restart the site 1. Confirm the server started 1. Confirm it wouldn't start on trunk
|
I'll go ahead and merge as this issue affects the VS Code extension |
johnhooks
pushed a commit
to johnhooks/playground-tools
that referenced
this pull request
Oct 11, 2024
* wp-now: create dummy commands and new package * wp-now: re-create wp-now folders using nx * wp-now: execute php code example * wp-now: add connect node proxy to php runtime * wp-now: download latest wp zip in .wp-now dir * wp-now: download wordpress and proxy requests fixing location * wp-now: remove unused run method * wp-now: clean unused imports * wp-now: css fixed, redirect fixed * wp-now: setup sqlite * wp-now: use express and change the response to bytes * wp-now: rename download lib * wp-now: add sqlite funciton * wp-now: move sqlite logic to nodejs and unify paths * wp-now: split create-server run-cli logic * wp-now: update yarn lock * wp-now: import HTTPMethod from abstract * wp-now: avoid importing abstract * wp-now: remove async from mountSqlite * wp-now: clean unnecesary cli * wp-now: fix imports after merge using NodePHP and universal * wp-now: change build phase to esbuild module * wp-now: remove clear console lines * wp-now: use portFinder for open port source of truth * wp-now: receive path as paramter * wp-now: accept path and mode, enable plugin mode * wp-now: infer mode plugin, theme, index or core * wp-now: infer mode static directory * wp-now: rename patchFile to updateFile * wp-now: add comments to constants * wp-now: reduce amount of child folders for sqlite * wp-now: run always wp-now cli mode Exmaple: nx preview wp-now start --path=/Users/macbookpro/gutenberg * wp-now: use path as a parameter instead of cwd() * wp-now: fix code style * wp-now: remove unnecessary log port number * wp-now: update SQLite plugin name under quotes * wp-now: remove node env suggestion from run-cli * wp-now: project.json run commands sequentially * wp-now: rename wordpress versions path * wp-now: fix code style * wp-now: rename requestBodyToMultipartFormData * wp-now: reuse defineSiteUrl * wp-now: include a WP-NOW Readme and copy it to dist * wp-now: improve the readme redaction * wp-now: improve the readme redaction * wp-now: add phpVersion parameter Closes: WordPress/wordpress-playground#232 * wp-now: fix code style * wp-now: default mode is index * wp-now: fix code style * wp-now: use dashes for wordpress-versions folder * wp-now: update readme * wp-now: remove wp-content argument to use only home directory * wp-now: rename phpVersion argument name to php * wp-now: pass php version value from php argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user may customize their login details. Changing the password should not prevent them from starting the server again. This PR adds tolerance for login() failures.
Other changes
This PR also bumps the VS Code extension version
Testing instructions