Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade @php-wasm/node to 0.6.16 #323

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Upgrade @php-wasm/node to 0.6.16 #323

merged 2 commits into from
Jul 3, 2024

Conversation

zaguiini
Copy link
Member

@zaguiini zaguiini commented Jul 3, 2024

What?

Bumps @php-wasm/node to the last version before breaking changes.

Why?

The main reason I'm bumping this is to catch up with the error handling included in 0.6.13...0.6.16, which improves the developer experience by not crashing the entire process and just reporting the error to the user in the output, allowing them to change the code and refresh the page instead of restarting the server.

Testing Instructions

  • Check all tests are passing;
  • Check that you can run wp-now with node <repo-root>/dist/packages/wp-now/main.js start after building it locally;
  • Check that throwing an error within the WP installation crashes the app but not the server;
  • Check that removing the error and refreshing the page works.

@zaguiini
Copy link
Member Author

zaguiini commented Jul 3, 2024

cc @sejas

Copy link
Collaborator

@sejas sejas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested wp-now introducing an error and I confirm now the server is still running even with php errors. After fixing the intentional php error, I don't need to restart wp-now.

Screen.Capture.on.2024-07-03.at.22-16-27.mp4

@sejas sejas merged commit 9cf722f into WordPress:trunk Jul 3, 2024
2 checks passed
@zaguiini zaguiini deleted the update/phpwasm-node-0.6.16 branch July 3, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants