-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Spell Check action #247
Conversation
Thanks @mukeshpanchal27. The output looks good, but it would be nice if these were all reported as warnings instead of causing the check to fail. Can you see if that's possible? |
Hello @joemcgill, it appears that the action didn't offer any configuration to generate warnings instead of errors. I've raised the issue and created a ticket here: crate-ci/typos#811 on the main repository. We will keep you posted once there are any updates on this matter. |
I think treating as errors is fine, but we should first merge that other PRs |
Thanks for checking, @mukeshpanchal27. Let's go ahead do what Pascal suggests, and merge the PR that fixes the current errors, and then merge trunk back into this PR to make sure we have things passing before merging this, so we don't introduce a blocker to other PRs. |
@joemcgill @felixarntz @swissspidy The PR is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mukeshpanchal27!
Follow-up of #245
Added new CI for Spell Check that show error at the moment.
Checklist: