-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TT1 Blocks: Delete front-page.html #179
Conversation
I think we do actually need a separate template here — since Twenty Twenty-One hides the homepage title on the homepage automatically. It should probably have a query block, but with no page title. |
If we did that, the list of blog posts would also not have titles. We do not have traditional PHP conditionals, but we do have CSS. We can work around it, but a long term solution .home:not(.blog) .wp-block-post-title, This would leave the .wp-block-separator above the content. That the Perhaps the solution is to allow themes to use .php files and unlimited PHP. Or, we need to introduce another context for "home" and "blog". |
Hmm. That's a good point. Perhaps for now we do remove the |
Yeah we will definitely need to fix this in Gutenberg. I created an issue here: WordPress/gutenberg#28564 Happy to remove the template for now, but I'd rather not fix it with CSS. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. This should be good to merge in the meantime!
Agreed front-page doesn't make much sense. The relationship between front-page, home, page template, and the static homepage setting are all a bit confusing in WordPress. Would it make sense to have a I think more generally we need make the "hide a title" something much more flexible across the board, for pages and posts alike — maybe a part of the post-title block setting a body-class or post-class. |
That's what I did here: https://github.com/WordPress/theme-experiments/pull/184/files |
Gutenberg's end-to-end tests were broken for a while after TT1 Blocks removed their `front-page` template (WordPress/theme-experiments#179) -- which our e2e tests relied on. This was fixed on the Gutenberg side in #28638. Per [this discussion](#28692 (comment)), we might be able to avoid a similar situation in the future by pinning our TT1 Blocks dependency to a given version. See #28692 for more background.
Solves #167