This repository has been archived by the owner on Dec 2, 2020. It is now read-only.
Add overlapping images block pattern #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjellr
added
Needs design feedback
[Component] Block patterns
melchoyce
approved these changes
Oct 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the "Overlapping Gallery" pattern from #50, but calls it "Overlapping Images" to better represent the blocks used in it.
It's a way simpler alternative to #277. The exact overlap here is a little different from the comps, so I'm interested in your thoughts, @melchoyce. Feel free to recommend any adjustments. It also loses the overlap completely on mobile, which is a little unfortunate. This is because of the way the columns block stacks its columns by default on mobile. We could change that, but I imagine we'd run into some issues.
^ Note that there looks to be a small bug in the tablet (EDIT: Fixed in #372760px) breakpoint. I'm going to dig into that, but its unrelated to this PR, so I think it can be handled separately.