Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

Changes to directory names #265

Merged
merged 1 commit into from
Nov 30, 2021
Merged

Conversation

mburridge
Copy link
Contributor

Changes the following directory names, as per issue #264 :

  • block-templates ➡️ templates
  • block-template-parts ➡️ parts

Copy link
Collaborator

@kjellr kjellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This works in my testing. 🙌

@kjellr
Copy link
Collaborator

kjellr commented Nov 29, 2021

After discussing with @jffng, we're going to hold off on merging for just a moment since this feature isn't merged into Beta 1 yet. Should be ready in a day or so!

@kafleg
Copy link
Member

kafleg commented Nov 30, 2021

We are not going to change the name under Appearance?
See this screenshot: https://i.rankmath.com/ViRosf

@tinjure20
Copy link

I was also wondering how about use in templates markup (example: here)?

@carolinan
Copy link
Collaborator

I was also wondering how about use in templates markup (example: here)?

The markup uses the source and slug for the block, wp:template-part, and the name of the template part block has not been changed, so we don't need to change anything there.

@carolinan
Copy link
Collaborator

We are not going to change the name under Appearance? See this screenshot: https://i.rankmath.com/ViRosf

I don't think so, there were discussions a few months ago, but not recently.

@kjellr
Copy link
Collaborator

kjellr commented Nov 30, 2021

The release bundled here has been committed to core for Beta 1, so I think we're good to merge this.

I think this'll mean folks need to test this GitHub edition of the theme against Gutenberg trunk until 12.1 comes out, but that should be fine since folks can still test the version bundled with Beta 1.

Thanks, everyone!

@kjellr kjellr merged commit 663fca6 into WordPress:trunk Nov 30, 2021
@mburridge mburridge deleted the rename-directories branch December 1, 2021 09:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants