Update the packages for 5.8 beta1 batch 2 #1351
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
reviewed
Jun 8, 2021
| */ | ||
| function gutenberg_register_legacy_query_loop_block() { | ||
| $registry = WP_Block_Type_Registry::get_instance(); | ||
| if ( $registry->is_registered( 'core/query-loop' ) ) { |
There was a problem hiding this comment.
Since we are removing now query-loop from core we can loose this check.
There was a problem hiding this comment.
This file is automatically brought from Gutenberg, so we can't do this here.
Another thing is that the function still has the gutenberg_ prefix (I think this should be removed in a follow-up).
These changes can be done after beta1 though.
ntsekouras
reviewed
Jun 8, 2021
| @@ -318,7 +318,8 @@ function _unhook_block_registration() { | |||
| remove_action( 'init', 'register_block_core_post_terms' ); | |||
| remove_action( 'init', 'register_block_core_post_title' ); | |||
| remove_action( 'init', 'register_block_core_query' ); | |||
| remove_action( 'init', 'register_block_core_query_loop' ); | |||
| remove_action( 'init', 'register_block_core_post_template' ); | |||
| remove_action( 'init', 'gutenberg_register_legacy_query_loop_block' ); | |||
There was a problem hiding this comment.
Should we remove the gutenberg prefix here?
ntsekouras
reviewed
Jun 8, 2021
|
committed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates WP to the latest WP packages. It includes the backports from WordPress/gutenberg#32508
Trac ticket: https://core.trac.wordpress.org/ticket/52991
See the diff in https://github.com/WordPress/gutenberg/pull/32508/files