Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block editor: iframe for block based themes (PHP backport) #3904

Conversation

ellatrix
Copy link
Member

@ellatrix ellatrix commented Jan 25, 2023

Trac ticket: https://core.trac.wordpress.org/ticket/57549
Gutenberg PR: WordPress/gutenberg#46212


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link
Contributor

@hellofromtonya hellofromtonya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The setting addition matches the change from https://github.com/WordPress/gutenberg/pull/46212/files#diff-6207ce64dd0d1f385378631f2127d8ee06ff954ca0e947d18e3d03cec4f6abe9. This is the complete PHP backport/sync 👍

This is ready for commit.

@hellofromtonya
Copy link
Contributor

Committed via changeset https://core.trac.wordpress.org/changeset/55147.

@ellatrix ellatrix deleted the backport/iframe-block-based-theme-post-editor branch February 2, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants