Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation submenu block: deprecate deleted block_core_navigation_submenu_build_css_colors function #4762

Conversation

ramonjd
Copy link
Member

@ramonjd ramonjd commented Jun 30, 2023

block_core_navigation_submenu_build_css_colors was deprecated in WordPress/gutenberg#48936 in favour of wp_apply_colors_support

This commit adds a deprecation to core.

See comment: https://github.com/WordPress/wordpress-develop/pull/4699/files#r1243172213

Props to @peterwilsoncc

Trac ticket: https://core.trac.wordpress.org/ticket/58623


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

…Press/gutenberg#48936 in favour of wp_apply_colors_support

this commit adds a deprecation to core
/**
* Build an array with CSS classes and inline styles defining the colors
* which will be applied to the navigation markup in the front-end.
*
Copy link
Member Author

@ramonjd ramonjd Jun 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@since 6.2.0 I think

Copy link
Contributor

@tellthemachines tellthemachines Jul 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@since 5.9.0, I remember adding it 😄

Copy link
Contributor

@tellthemachines tellthemachines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Added the @since in.

@tellthemachines
Copy link
Contributor

Committed in r56126 / ab9d5e3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants