Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport to 6.3 - Navigation: Load the raw property on the navigation fallback #4891

Conversation

ramonjd
Copy link
Member

@ramonjd ramonjd commented Jul 24, 2023

Backports the following Gutenberg PR:

cc @scruffian @getdave

Trac ticket: https://core.trac.wordpress.org/ticket/58557


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Updated typo in wp_add_fields_to_navigation_fallback_embeded_links
Added tests (failing)
Copy link

@scruffian scruffian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good now.

ramonjd added a commit to WordPress/gutenberg that referenced this pull request Jul 24, 2023
Copy link
Contributor

@tellthemachines tellthemachines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM!

@tellthemachines
Copy link
Contributor

Committed in r56296 to trunk / r56297 to 6.3.

ramonjd added a commit to WordPress/gutenberg that referenced this pull request Jul 25, 2023
* Fix image block v6 deprecation (#52822)

* Remove incorrect comment

* Add missing attribtes and supports

* Add integration tests for the deprecation

* Fix incorrect import

* Fix fixtures

* Image: Use the correct method for caption class in recent deprecation (#52853)

* Distraction Free: Fix notices in site editor (#52867)

* Distraction Free: Add missing command in site editor (#52868)

* Site Editor: Fix the template parts link on the list page (#52891)

* Return focus more from focus return hook (#52710)

* Disambiguate "Import" button string. (#52907)

* Disambiguate "Import" button string.

* Add _x to import

---------

Co-authored-by: Andrew Serong <14988353+andrewserong@users.noreply.github.com>

* My patterns page: Increase color contrast for the toggle group (#52678)

* Update style.scss

* Update style.scss

* Check if object exists before accessing its properties. (#52870)

* Check if object exists before accessing its properties.

* Name anonymous functions

* Update names

* Sidebar: Restore Back buton 'go to parent' functionality (#52910)

* Global styles revisions: display text if no revisions are found (#52865)

* If somehow a user lands on the revisions panel when there are no revisions, show some helpful text rather than a loading spinner. Also, add an E2E test!

* Updated unit tests to reflect resolver logic changes

* Use existing string

* Only open edit view when testing the revisions panel itself

* ResizableFrame: Account for window resizing (#52697)

* ResizableFrame: Account for window resizing

* Don't memoize

---------

Co-authored-by: Robert Anderson <robert@noisysocks.com>

* Distraction Free: Fix conflict with showListViewByDefault preference (#52914)

* Backporting changes from WordPress/wordpress-develop#4891

* Site Editor: Open template parts in view canvas view mode (#52916)

---------

Co-authored-by: Alex Lende <alex+github.com@lende.xyz>
Co-authored-by: George Mamadashvili <georgemamadashvili@gmail.com>
Co-authored-by: Andrew Serong <14988353+andrewserong@users.noreply.github.com>
Co-authored-by: Mitchell Austin <mr.fye@oneandthesame.net>
Co-authored-by: Jb Audras <audrasjb@gmail.com>
Co-authored-by: Carolina Nymark <myazalea@hotmail.com>
Co-authored-by: Robert Anderson <robert@noisysocks.com>
Co-authored-by: Ramon <ramonjd@users.noreply.github.com>
Co-authored-by: Lena Morita <lena@jaguchi.com>
Co-authored-by: ramon <ramonjd@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

5 participants