Lightbox: Re-use existing Tag Processor instance. #5428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmsnell
added a commit
to WordPress/gutenberg
that referenced
this pull request
Oct 11, 2023
Companion work in WordPress/wordpress-develop#5428 Resolves #55123 This patch refactors the use of the HTML API in image lightbox rendering. It replaces creating multiple Tag Processor instances with the use of a single instance that rewinds and jumps around to perform multiple jobs on a single instance. Also incorporated is a fix for bailing out when no images are in a given image block's output HTML.
dmsnell
force-pushed
the
update/lightbox-html-api-use
branch
3 times, most recently
from
f924e03
to
fcb9061
Compare
Resolves WordPress/gutenberg#55123 Replaces existing single-letter-named Tag Processor instances with a single processor that's reuse throughout the function. As a work-in-progress (WIP) patch, this is a preliminary exploration and not ready for review or merging.
dmsnell
force-pushed
the
update/lightbox-html-api-use
branch
from
fcb9061
to
e47a3d0
Compare
dmsnell
added a commit
to WordPress/gutenberg
that referenced
this pull request
Oct 15, 2023
Companion work in WordPress/wordpress-develop#5428 Resolves #55123 This patch refactors the use of the HTML API in image lightbox rendering. It replaces creating multiple Tag Processor instances with the use of a single instance that rewinds and jumps around to perform multiple jobs on a single instance. Also incorporated is a fix for bailing out when no images are in a given image block's output HTML.
dmsnell
added a commit
to WordPress/gutenberg
that referenced
this pull request
Oct 16, 2023
Companion work in WordPress/wordpress-develop#5428 Resolves #55123 This patch refactors the use of the HTML API in image lightbox rendering. It replaces creating multiple Tag Processor instances with the use of a single instance that rewinds and jumps around to perform multiple jobs on a single instance. Also incorporated is a fix for bailing out when no images are in a given image block's output HTML.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes:
Description:
Resolves WordPress/gutenberg#55123
Replaces existing single-letter-named Tag Processor instances with a single processor that's reuse throughout the function.
As a work-in-progress (WIP) patch, this is a preliminary exploration and not ready for review or merging.
cc: @artemiomorales @afercia