Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML API: Test and fix HTML Processor bookmarks #6039

Closed
wants to merge 10 commits into from
Closed

HTML API: Test and fix HTML Processor bookmarks #6039

wants to merge 10 commits into from

Commits on Feb 8, 2024

  1. Add tests

    @sirreal
    sirreal committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    8281f06 View commit details
    Browse the repository at this point in the history

  2. Add has_bookmark to HTML processor

    @sirreal
    sirreal committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    920b7a6 View commit details
    Browse the repository at this point in the history

  3. Create HTML Processor through static creator method not constructor

    @dmsnell @sirreal
    dmsnell authored and sirreal committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    f0537a1 View commit details
    Browse the repository at this point in the history

  4. HTML Processor does not expose tag closers in next_tag()

    @dmsnell @sirreal
    dmsnell authored and sirreal committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    073847b View commit details
    Browse the repository at this point in the history

  5. Flush pending udpates before seeking in HTML Processor

    @dmsnell @sirreal
    dmsnell authored and sirreal committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    0cdcf93 View commit details
    Browse the repository at this point in the history

  6. Allow leniency in the bookmark limit test, because of internal 

    bookmarks.
    @dmsnell @sirreal
    dmsnell authored and sirreal committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    58f4735 View commit details
    Browse the repository at this point in the history

  7. the test runner is looking at the base class, not the subclass

    @dmsnell @sirreal
    dmsnell authored and sirreal committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    5746abb View commit details
    Browse the repository at this point in the history

  8. The Tag Processor asserts its own limit on seeking, so the HTML 

    Processor doesn't need to. Same with bookmarks.
    @dmsnell @sirreal
    dmsnell authored and sirreal committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    4a81537 View commit details
    Browse the repository at this point in the history

  9. Remove another test that doesn't need to exist also in the HTML 

    Processor
    @dmsnell @sirreal
    dmsnell authored and sirreal committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    73843e1 View commit details
    Browse the repository at this point in the history

  10. Add docblock

    @sirreal
    sirreal committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    afa9e76 View commit details
    Browse the repository at this point in the history