HTML Processor: Ensure is_tag_closer is correctly called #6726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The is_tag_closer() method is not static and should be called as an instance method.
In order to respect stack operations the HTML Processor should call its implementation of the is_tag_closer() method in the next_tag method.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
sirreal
commented
Jun 4, 2024
| @@ -463,7 +463,7 @@ public function next_tag( $query = null ) { | |||
| continue; | |||
| } | |||
|
|
|||
| if ( ! parent::is_tag_closer() || $visit_closers ) { | |||
| if ( ! $this->is_tag_closer() || $visit_closers ) { | |||
There was a problem hiding this comment.
@dmsnell This came up here: #6348 (comment)
I haven't been able to come up with a failing test case for it.
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
dmsnell
approved these changes
Jun 8, 2024
pento
pushed a commit
that referenced
this pull request
Jun 8, 2024
The HTML Processor had been calling the parent class `is_tag_closer()` method, but since visiting virtual nodes was introduced, it's important that all of the methods are called on the subclass. This patch fixes one issue identified where the parent method was called instead, and it fixes another case where the change from calling the parent method to the `$this` method was done improperly. Developed in #6726 Discussed in https://core.trac.wordpress.org/ticket/61348 Props jonsurrell. See #61348. Follow-up to [58304]. git-svn-id: https://develop.svn.wordpress.org/trunk@58365 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to WordPress/WordPress
that referenced
this pull request
Jun 8, 2024
The HTML Processor had been calling the parent class `is_tag_closer()` method, but since visiting virtual nodes was introduced, it's important that all of the methods are called on the subclass. This patch fixes one issue identified where the parent method was called instead, and it fixes another case where the change from calling the parent method to the `$this` method was done improperly. Developed in WordPress/wordpress-develop#6726 Discussed in https://core.trac.wordpress.org/ticket/61348 Props jonsurrell. See #61348. Follow-up to [58304]. Built from https://develop.svn.wordpress.org/trunk@58365 git-svn-id: http://core.svn.wordpress.org/trunk@57814 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot
pushed a commit
to platformsh/wordpress-performance
that referenced
this pull request
Jun 8, 2024
The HTML Processor had been calling the parent class `is_tag_closer()` method, but since visiting virtual nodes was introduced, it's important that all of the methods are called on the subclass. This patch fixes one issue identified where the parent method was called instead, and it fixes another case where the change from calling the parent method to the `$this` method was done improperly. Developed in WordPress/wordpress-develop#6726 Discussed in https://core.trac.wordpress.org/ticket/61348 Props jonsurrell. See #61348. Follow-up to [58304]. Built from https://develop.svn.wordpress.org/trunk@58365 git-svn-id: https://core.svn.wordpress.org/trunk@57814 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac Ticket: Core-61348
This is a follow-up to 163c3fd / #6348 with two small fixes:
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.