HTML API: Join successive text nodes in html5lib test representation. #6984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many tests from the html5lib test suite fail because of differences in text handling between a DOM API and the HTML API, even though the semantics of the parse are equivalent. For example, it's possible in the HTML API to read multiple successive text nodes when the tokens between them are ignored. The test suite didn't account for this and so was failing tests. This patch improves the construction of the representation to compare against the test suite so that those tests don't fail inaccurately.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Trac Ticket MissingThis pull request is missing a link to a Trac ticket. For a contribution to be considered, there must be a corresponding ticket in Trac. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. More information about contributing to WordPress on GitHub can be found in the Core Handbook. |
19 tasks
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
pento
pushed a commit
that referenced
this pull request
Jul 12, 2024
Many tests from the html5lib test suite fail because of differences in text handling between a DOM API and the HTML API, even though the semantics of the parse are equivalent. For example, it's possible in the HTML API to read multiple successive text nodes when the tokens between them are ignored. The test suite didn't account for this and so was failing tests. This patch improves the construction of the representation to compare against the test suite so that those tests don't fail inaccurately. Developed in #6984 Discussed in https://core.trac.wordpress.org/ticket/61576 Props bernhard-reiter, dmsnell, jonsurrell. See #61576. git-svn-id: https://develop.svn.wordpress.org/trunk@58712 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Jul 12, 2024
Many tests from the html5lib test suite fail because of differences in text handling between a DOM API and the HTML API, even though the semantics of the parse are equivalent. For example, it's possible in the HTML API to read multiple successive text nodes when the tokens between them are ignored. The test suite didn't account for this and so was failing tests. This patch improves the construction of the representation to compare against the test suite so that those tests don't fail inaccurately. Developed in WordPress/wordpress-develop#6984 Discussed in https://core.trac.wordpress.org/ticket/61576 Props bernhard-reiter, dmsnell, jonsurrell. See #61576. Built from https://develop.svn.wordpress.org/trunk@58712 git-svn-id: http://core.svn.wordpress.org/trunk@58114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot
pushed a commit
to gilzow/wordpress-performance
that referenced
this pull request
Jul 12, 2024
Many tests from the html5lib test suite fail because of differences in text handling between a DOM API and the HTML API, even though the semantics of the parse are equivalent. For example, it's possible in the HTML API to read multiple successive text nodes when the tokens between them are ignored. The test suite didn't account for this and so was failing tests. This patch improves the construction of the representation to compare against the test suite so that those tests don't fail inaccurately. Developed in WordPress/wordpress-develop#6984 Discussed in https://core.trac.wordpress.org/ticket/61576 Props bernhard-reiter, dmsnell, jonsurrell. See #61576. Built from https://develop.svn.wordpress.org/trunk@58712 git-svn-id: https://core.svn.wordpress.org/trunk@58114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Debarghya-Banerjee
pushed a commit
to Debarghya-Banerjee/wordpress-develop
that referenced
this pull request
Jul 18, 2024
Many tests from the html5lib test suite fail because of differences in text handling between a DOM API and the HTML API, even though the semantics of the parse are equivalent. For example, it's possible in the HTML API to read multiple successive text nodes when the tokens between them are ignored. The test suite didn't account for this and so was failing tests. This patch improves the construction of the representation to compare against the test suite so that those tests don't fail inaccurately. Developed in WordPress#6984 Discussed in https://core.trac.wordpress.org/ticket/61576 Props bernhard-reiter, dmsnell, jonsurrell. See #61576. git-svn-id: https://develop.svn.wordpress.org/trunk@58712 602fd350-edb4-49c9-b593-d223f7449a82
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket: Core-61576
Many tests from the html5lib test suite fail because of differences in
text handling between a DOM API and the HTML API, even though the
semantics of the parse are equivalent. For example, it's possible in
the HTML API to read multiple successive text nodes when the tokens
between them are ignored.
The test suite didn't account for this and so was failing tests. This
patch improves the construction of the representation to compare
against the test suite so that those tests don't fail inaccurately.
Testing
Several tests were able to be removed from the skip group after this change.