Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: grid block issue #7001

Open
wants to merge 12 commits into
base: trunk
Choose a base branch
from
Open

Fix: grid block issue #7001

wants to merge 12 commits into from

Conversation

up1512001
Copy link
Member

@up1512001 up1512001 commented Jul 9, 2024

Trac ticket: https://core.trac.wordpress.org/ticket/61611

GB Issue: WordPress/gutenberg#63300

Automattic Issue: Automattic/themes#7943

This is an issue with the TT1 theme I checked it's due to this code present in the style.css file at the 2154 line number.

.wp-block-group:before,
.wp-block-group:after {
	content: "";
	display: block;
	clear: both;
}

before removing this code

Screenshot 2024-07-09 at 23 35 24

after removing this code

Screenshot 2024-07-09 at 23 35 50

Copy link

github-actions bot commented Jul 9, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props up1512001, karmatosed.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

github-actions bot commented Jul 9, 2024

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@karmatosed
Copy link
Member

@up1512001 this appears to have some merge conflicts. I am going to re-run tests but if this continues I will need you to check the PR here.

@up1512001
Copy link
Member Author

@up1512001 this appears to have some merge conflicts. I am going to re-run tests but if this continues I will need you to check the PR here.

@karmatosed resolved merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants