Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML API: Test improvements #7030

Closed
wants to merge 4 commits into from

Conversation

sirreal
Copy link
Member

@sirreal sirreal commented Jul 15, 2024

  • Use get_token_name over get_tag
  • Prefer assertSame

Follow-up to:

Trac ticket: https://core.trac.wordpress.org/ticket/61646


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

sirreal added 2 commits July 15, 2024 16:52
get_token_name will be the tag name when on tags, or a meaningful token name otherwise.
This is helpful in test failure message in case we may not be on a tag.
assertSame (strict equals) should be preferred when possible.
@sirreal
Copy link
Member Author

sirreal commented Jul 15, 2024

Follow-up to: [58592]

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

pento pushed a commit that referenced this pull request Jul 17, 2024
Follow-up after feedback to newly-introduced tests,
mostly to enhance the message when the tests fail.

Developed in #7030
Discussed in https://core.trac.wordpress.org/ticket/61646

Follow-up to [58592].

Props dmsnell, jonsurrell.
See #61646.


git-svn-id: https://develop.svn.wordpress.org/trunk@58741 602fd350-edb4-49c9-b593-d223f7449a82
@dmsnell
Copy link
Member

dmsnell commented Jul 17, 2024

Merged in [58741]
8f11947

@dmsnell dmsnell closed this Jul 17, 2024
@dmsnell dmsnell deleted the html-api/test-improvements branch July 17, 2024 00:34
markjaquith pushed a commit to markjaquith/WordPress that referenced this pull request Jul 17, 2024
Follow-up after feedback to newly-introduced tests,
mostly to enhance the message when the tests fail.

Developed in WordPress/wordpress-develop#7030
Discussed in https://core.trac.wordpress.org/ticket/61646

Follow-up to [58592].

Props dmsnell, jonsurrell.
See #61646.

Built from https://develop.svn.wordpress.org/trunk@58741


git-svn-id: http://core.svn.wordpress.org/trunk@58143 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot pushed a commit to platformsh/wordpress-performance that referenced this pull request Jul 17, 2024
Follow-up after feedback to newly-introduced tests,
mostly to enhance the message when the tests fail.

Developed in WordPress/wordpress-develop#7030
Discussed in https://core.trac.wordpress.org/ticket/61646

Follow-up to [58592].

Props dmsnell, jonsurrell.
See #61646.

Built from https://develop.svn.wordpress.org/trunk@58741


git-svn-id: https://core.svn.wordpress.org/trunk@58143 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Debarghya-Banerjee pushed a commit to Debarghya-Banerjee/wordpress-develop that referenced this pull request Jul 18, 2024
Follow-up after feedback to newly-introduced tests,
mostly to enhance the message when the tests fail.

Developed in WordPress#7030
Discussed in https://core.trac.wordpress.org/ticket/61646

Follow-up to [58592].

Props dmsnell, jonsurrell.
See #61646.


git-svn-id: https://develop.svn.wordpress.org/trunk@58741 602fd350-edb4-49c9-b593-d223f7449a82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants