Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first pass at compat.php checker #7090

Draft
wants to merge 4 commits into
base: trunk
Choose a base branch
from

Conversation

aaronjorbin
Copy link
Member

@aaronjorbin aaronjorbin commented Jul 25, 2024

Trac ticket: https://core.trac.wordpress.org/ticket/61694


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@peterwilsoncc
Copy link
Contributor

Is it possible to do this as a custom sniff rather than a separate action?

That will allow the errors to display in IDEs rather than relying on contributors pushing PRs which may not always happen. There is some prior art for custom sniffs in the Gutenberg Repo https://github.com/WordPress/gutenberg/tree/trunk/test/php/gutenberg-coding-standards

I'm not sure it's worth putting in the main WPCS repo (others may have a different view)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants