HTML API: Improve skipped test reporting with unsupported exception #7285
Conversation
|
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
This reverts commit d460da3.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
| } catch ( WP_HTML_Unsupported_Exception $e ) { | ||
| $this->markTestSkipped( "Unsupported markup: {$e->getMessage()}" ); | ||
| return; | ||
| } | ||
|
|
||
| if ( null === $processed_tree ) { | ||
| $this->markTestSkipped( 'Test includes unsupported markup.' ); |
There was a problem hiding this comment.
This is probably inaccurate now, the unsupported markup messages should appear above.
I'd like to improve the other error cases because returning null can't express all of them. I've been thinking about adding more classes to handle them.
|
@sirreal I added new sections to throw an error on incomplete input and on an error that isn't unsupported markup (e.g. out of bookmarks) |
The `html5lib-tests` suite skips a number of tests due to unsupported markup. At the moment, these tests all report "Test includes unsupported markup." This patch calls the `get_unsupported_exception()` method in these skipped cases to improve the messages reported to PHPUnit so they're more informative: e.g. "Unsupported markup: Foster parenting is not supported." Developed in #7285 Discussed in https://core.trac.wordpress.org/ticket/61646 Follow-up to [58714]. Props dmsnell, jonsurrell. See #61646. git-svn-id: https://develop.svn.wordpress.org/trunk@58971 602fd350-edb4-49c9-b593-d223f7449a82
The `html5lib-tests` suite skips a number of tests due to unsupported markup. At the moment, these tests all report "Test includes unsupported markup." This patch calls the `get_unsupported_exception()` method in these skipped cases to improve the messages reported to PHPUnit so they're more informative: e.g. "Unsupported markup: Foster parenting is not supported." Developed in WordPress/wordpress-develop#7285 Discussed in https://core.trac.wordpress.org/ticket/61646 Follow-up to [58714]. Props dmsnell, jonsurrell. See #61646. Built from https://develop.svn.wordpress.org/trunk@58971 git-svn-id: http://core.svn.wordpress.org/trunk@58367 1a063a9b-81f0-0310-95a4-ce76da25c4cd
The `html5lib-tests` suite skips a number of tests due to unsupported markup. At the moment, these tests all report "Test includes unsupported markup." This patch calls the `get_unsupported_exception()` method in these skipped cases to improve the messages reported to PHPUnit so they're more informative: e.g. "Unsupported markup: Foster parenting is not supported." Developed in WordPress/wordpress-develop#7285 Discussed in https://core.trac.wordpress.org/ticket/61646 Follow-up to [58714]. Props dmsnell, jonsurrell. See #61646. Built from https://develop.svn.wordpress.org/trunk@58971 git-svn-id: https://core.svn.wordpress.org/trunk@58367 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Trac ticket: Core-61646
Improve unsupported markup skipped test information.
The html5lib-tests suite skips a number of tests due to unsupported markup. At the moment, these tests all report "Test includes unsupported markup." Use the
get_unsupported_exceptionmethod to improve these skip messages so they're more informative: "Unsupported markup: Foster parenting is not supported."There is no diff in the test statistics comparing this branch to trunk.
To test this, run the following and the improved error messages will be shown:
Here are a selection of test outputs for skipped tests.
Before
After
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.