Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Twenty Twenty-five to Performance Tests #7688

Closed
wants to merge 3 commits into from

Conversation

pbearne
Copy link

@pbearne pbearne commented Oct 30, 2024

Changed the default value of the baseline version from 6.1.1 to 6.6.2 in the reusable-performance.yml workflow file. This ensures the workflow uses the latest baseline version for performance measurements.

Trac ticket: https://core.trac.wordpress.org/ticket/62148

Changed the default value of the baseline version from 6.1.1 to 6.6.2 in the reusable-performance.yml workflow file. This ensures the workflow uses the latest baseline version for performance measurements.
Copy link

github-actions bot commented Oct 30, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @pbearne@git.wordpress.org.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

Core Committers: Use this line as a base for the props when committing in SVN:

Props joemcgill, flixos90.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Updated the home test suite to include the new twentytwentyfive theme. This ensures the tests cover all available themes and identify any potential performance issues specific to the new theme.
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder whether we should bump this to 6.7 instead, now that it's out? Since we're early in the release cycle, maybe now would be a good time for such a change, as we're not yet in the critical phase where likely more changes land that may impact performance.

@joemcgill
Copy link
Member

I wonder whether we should bump this to 6.7 instead, now that it's out?

I think we should give this a try. We've not updated the baseline version since the performance tests were first introduced, so now would be a good time to try this prior to any code syncs being merged into the core repo for this release.

@joemcgill joemcgill changed the title Update default baseline version to 6.6.2 in workflow Add Twenty Twenty-five to Performance Tests Dec 13, 2024
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pbearne This looks great to me, and I think now would be a good time to merge it.

One comment, but not a blocker.

.github/workflows/reusable-performance.yml Show resolved Hide resolved
@felixarntz
Copy link
Member

@joemcgill

I wonder whether we should bump this to 6.7 instead, now that it's out?

I think we should give this a try. We've not updated the baseline version since the performance tests were first introduced, so now would be a good time to try this prior to any code syncs being merged into the core repo for this release.

We're still early enough in the 6.8 cycle IMO so that I think it would be reasonable to commit this now. I think it would be great to do so this week.

Copy link
Contributor

@desrosj desrosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I say let's give it a go. Though I have one question. Are there any changes required upstream where we submit the reports? Not sure if changing the baseline would impart how the reports are consumed or displayed.

@swissspidy
Copy link
Member

@swissspidy swissspidy closed this Dec 17, 2024
@swissspidy
Copy link
Member

Are there any changes required upstream where we submit the reports?

If we wanna send the data there and display it there, actually, yes. We need to update tests/performance/log-results.js and also Riad will need to add it to the dashboard. But I think we should only do that when we add some sort of filter there...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants