Move the notoptions lookup before the options cache lookup #8030
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
| if ( isset( $alloptions[ $option ] ) ) { | ||
| $value = $alloptions[ $option ]; | ||
| } else { | ||
| // Check for non-existent options first to avoid unnecessary object cache lookups and DB hits. | ||
| $notoptions = wp_cache_get( 'notoptions', 'options' ); |
There was a problem hiding this comment.
Would it make sense to use wp_cache_get_multiple here?
$options = wp_cache_get_multiple( array( 'notoptions', $option ), 'options' );
$notoptions = $options['notoptions'] ?? array();
$value = $options[$option] ?? false;
There was a problem hiding this comment.
I don't think so, because the goal is to avoid the call to the object cache for the option at all if it doesn't exist. If we could get the alloptions and notoptions cache values in one request, that would be an improvement, but not a very meaningful one.
One thing to consider about the call to wp_cache_get( 'notoptions', 'options' ); is that the first time it is called, it will do check the external object cache if available, but then additional calls in the same request will already have that value in memory.
| // Prevent non-existent `notoptions` key from triggering multiple key lookups. | ||
| if ( ! is_array( $notoptions ) ) { | ||
| $notoptions = array(); | ||
| wp_cache_set( 'notoptions', $notoptions, 'options' ); |
There was a problem hiding this comment.
It appears that this line (initializing notoptions in the cache to an empty array) is removed entirely in this PR? Is that intentional? Is this line no longer needed?
Trac ticket: https://core.trac.wordpress.org/ticket/62692
This is an alternate approach to #8004 which moves the check of 'notoptions' before checking the 'options' cache while leaving the 'alloptions' check first.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.