Skip to content

Commit

Permalink
Website: Add secrets on-demand for more endpoints (#1362)
Browse files Browse the repository at this point in the history
## What is this PR doing?

Adds secrets on demand for PHP endpoints that need them.

Related to #1197

## What problem is it solving?

We are not yet relaying secrets required by the endpoints
`plugin-proxy.php` and `oauth.php`.

## How is the problem addressed?

This PR adds secrets as environment variables when requests for those
endpoints are processed.

## Testing Instructions

- Test briefly on the WP Cloud staging site
- Test use of the updates to identify files-to-serve-via-php during
deployment
  • Loading branch information
brandonpayton authored May 4, 2024
1 parent d09f8bc commit b951c05
Showing 1 changed file with 63 additions and 12 deletions.
75 changes: 63 additions & 12 deletions packages/playground/website-deployment/custom-redirects-lib.php
Original file line number Diff line number Diff line change
Expand Up @@ -206,23 +206,72 @@ function playground_maybe_set_environment( $requested_path ) {
}

if ( str_ends_with( $requested_path, 'logger.php' ) ) {
// WORKAROUND: Atomic_Persistent_Data wants the DB_PASSWORD constant
// which is not set yet. But we can force its definition.
__atomic_env_define( 'DB_PASSWORD' );

$secrets = new Atomic_Persistent_Data;
if ( isset(
$secrets->LOGGER_SLACK_CHANNEL,
$secrets->LOGGER_SLACK_TOKEN,
) ) {
putenv( "SLACK_CHANNEL={$secrets->LOGGER_SLACK_CHANNEL}" );
putenv( "SLACK_TOKEN={$secrets->LOGGER_SLACK_TOKEN}" );
// TODO: Remove this condition when we can confirm __atomic_env_define() is again always defined
if ( function_exists( '__atomic_env_define' ) ) {
// WORKAROUND: Atomic_Persistent_Data wants the DB_PASSWORD constant
// which is not set yet. But we can force its definition.
__atomic_env_define( 'DB_PASSWORD' );

$secrets = new Atomic_Persistent_Data;
if ( isset(
$secrets->LOGGER_SLACK_CHANNEL,
$secrets->LOGGER_SLACK_TOKEN,
) ) {
putenv( "SLACK_CHANNEL={$secrets->LOGGER_SLACK_CHANNEL}" );
putenv( "SLACK_TOKEN={$secrets->LOGGER_SLACK_TOKEN}" );
} else {
error_log( 'PLAYGROUND: Missing secrets for logger.php' );
}
} else {
error_log( 'PLAYGROUND: Unable to access secrets for logger.php' );
}

return true;
}

if ( str_ends_with( $requested_path, 'plugin-proxy.php' ) ) {
// TODO: Remove this condition when we can confirm __atomic_env_define() is again always defined
if ( function_exists( '__atomic_env_define' ) ) {
// WORKAROUND: Atomic_Persistent_Data wants the DB_PASSWORD constant
// which is not set yet. But we can force its definition.
__atomic_env_define( 'DB_PASSWORD' );

$secrets = new Atomic_Persistent_Data;
if ( isset( $secrets->GITHUB_TOKEN ) ) {
putenv( "GITHUB_TOKEN={$secrets->GITHUB_TOKEN}" );
} else {
error_log( 'PLAYGROUND: Missing secrets for plugin-proxy.php' );
}
} else {
error_log( 'PLAYGROUND: Missing secrets for logger.php' );
error_log( 'PLAYGROUND: Unable to access secrets for plugin-proxy.php' );
}
return true;
}

if ( str_ends_with( $requested_path, 'oauth.php' ) ) {
// TODO: Remove this condition when we can confirm __atomic_env_define() is again always defined
if ( function_exists( '__atomic_env_define' ) ) {
// WORKAROUND: Atomic_Persistent_Data wants the DB_PASSWORD constant
// which is not set yet. But we can force its definition.
__atomic_env_define( 'DB_PASSWORD' );

$secrets = new Atomic_Persistent_Data;
if ( isset(
$secrets->GITHUB_APP_CLIENT_ID,
$secrets->GITHUB_APP_CLIENT_SECRET,
) ) {
putenv( "GITHUB_APP_CLIENT_ID={$secrets->GITHUB_APP_CLIENT_ID}" );
putenv( "GITHUB_APP_CLIENT_SECRET={$secrets->GITHUB_APP_CLIENT_SECRET}" );
} else {
error_log( 'PLAYGROUND: Missing secrets for oauth.php' );
}
} else {
error_log( 'PLAYGROUND: Unable to access secrets for oauth.php' );
}
return true;
}


return false;
}

Expand All @@ -245,6 +294,7 @@ function playground_get_custom_response_headers( $filename ) {
'index.js',
'blueprint-schema.json',
'logger.php',
'oauth.php',
'wp-cli.phar',
'wordpress-importer.zip',
),
Expand All @@ -269,3 +319,4 @@ function playground_resolve_to_index_file( $real_path ) {
return false;
}
}

0 comments on commit b951c05

Please sign in to comment.