Try: Reduce the C API to just phpwasm_run
#106
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These explorations reduce the surface of the C API from
["_phpwasm_init_context", "_phpwasm_destroy_context", "_phpwasm_run", "_phpwasm_refresh", "_phpwasm_init_uploaded_files_hash", "_phpwasm_register_uploaded_file", "_phpwasm_destroy_uploaded_files_hash"]
to just["_phpwasm_run"]
. This PR is draft-y, exploratory, and isn't meant for merging. It's just my way of sharing some thoughts in public.The changes proposed mostly work, however this problem is blocking:
More prominently, there's a problem of shaping the API:
php://input
. JS could reuse the raw request data, but that would potentially process large multipart-encoded files twice.I'm not sure what's the best way to proceed yet.