Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autopublish npm packages every week #1542

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Conversation

adamziel
Copy link
Collaborator

@adamziel adamziel commented Jun 26, 2024

Motivation for the change, related issues

Publishes Playground packages every week to enable integrators to stay on top of the latest changes.

The manual "publish when needed" approach we've used so far is no longer suitable. It was based on an assumption that the most interested developers will keep up with the project and ask for a new release when needed. In reality people tend to keep up with the npm packages, not the GitHub repo. A few developers reached out and directly asked for more frequent releases.

This PR ensures there's a patch release every Monday. Let's see how well it works and continue iterating on the approach should any problems arise. In the future, we might want to explore formal release trains, beta periods, and such, but today I believe we can get away with a much leaner approach.

@mho22
Copy link
Contributor

mho22 commented Jun 28, 2024

@adamziel I noticed that the @php-wasm npm packages have been updated, except for @php-wasm/web and @php-wasm/node. Is this expected?

Capture d’écran 2024-06-28 à 12 07 12

@adamziel adamziel linked an issue Jun 29, 2024 that may be closed by this pull request
@adamziel adamziel removed a link to an issue Jun 29, 2024
@adamziel adamziel self-assigned this Jul 3, 2024
@adamziel
Copy link
Collaborator Author

adamziel commented Jul 3, 2024

@mho22 not intended at all, that's a bug and we should fix it – thank you for reporting

@mho22
Copy link
Contributor

mho22 commented Jul 3, 2024

@adamziel There seems to be an issue on line: lerna verb publish @php-wasm/node. Should I open an issue instead of commenting here?
Capture d’écran 2024-07-03 à 17 25 32

@adamziel
Copy link
Collaborator Author

adamziel commented Jul 3, 2024

Yes please, thank you @mho22 !

@adamziel adamziel marked this pull request as ready for review July 8, 2024 11:01
@adamziel adamziel merged commit cbfeb96 into trunk Jul 8, 2024
5 checks passed
@adamziel adamziel deleted the autopublish-npm-packages branch July 8, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants