Worker boot: Parallelize WP.zip and PHP.wasm download #1668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WordPress were downloaded in parallel. After that PR,
WordPress.zip download was awaited before the PHP.wasm download
would start. In here, we're removing the extra `await` statements
to parallelize all the downloads.
This is a stopgap PR until we can clean up the worker-thread.ts boot
flow and control the boot sequence from remote.html. Then, API calls
like `mountOPFSDir()` or `bootPHP()` would become explicit.
## Testing instructions
* Go to http://localhost:5400/website-server/?wp=http://localhost:5400/plugin-proxy.php?url=https://wordpress.org/wordpress-6.6.1.zip
* In network devtools, confirm that PHP was downloaded without waiting
for wordpress-6.6.1.zip
adamziel
added
[Type] Bug
Closed
|
Superseded by #1669 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1390 introduced a regression in the asset loading flow.
WordPress were downloaded in parallel. After that PR,
WordPress.zip download was awaited before the PHP.wasm download
would start. In here, we're removing the extra
awaitstatementsto parallelize all the downloads.
I'm not yet certain whether it solves the progress bar issue.
This is a stopgap PR until we can clean up the worker-thread.ts boot flow and control the boot sequence from remote.html. Then, API calls like
mountOPFSDir()orbootPHP()would become explicit.Related to #1667.
Testing instructions