Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Website] Prevent creation of two temporary sites #1817

Merged
merged 2 commits into from
Sep 28, 2024
Merged

[Website] Prevent creation of two temporary sites #1817

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d21ce23
[Website] Prevent creation of two temporary sites
adamziel Sep 27, 2024
35cd4d9
Restore comment
adamziel Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ...ound/website/src/components/ensure-playground-site/ensure-playground-site-is-selected.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,14 @@ export function EnsurePlaygroundSiteIsSelected({
return;
}

// Don't create a new temporary site until the site listing settles.
// Otherwise, the status change from "loading" to "loaded" would
// re-run this entire effect, potentially leading to multiple
// sites being created since we couldn't look for duplicates yet.
if (!['loaded', 'error'].includes(siteListingStatus)) {
return;
}

// If the site slug is missing, create a new temporary site.
// Lean on the Query API parameters and the Blueprint API to
// create the new site.
Expand Down
Loading