-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken Playwright tests #1819
Conversation
The Blueprint tests are still failing, and I'm looking into it. |
Actually, the Blueprint tests were fine but anything related to WP multisite fails when the local server has a non-standard port (5400 in our case). |
@@ -13,7 +13,7 @@ export const playwrightConfig: PlaywrightTestConfig = { | |||
/* Retry on CI only */ | |||
retries: process.env.CI ? 2 : 0, | |||
/* Opt out of parallel tests on CI. */ | |||
workers: 1, | |||
workers: process.env.CI ? 1 : 3, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bgrgicak, why do we opt out of parallel tests on CI, and should we continue opting out of parallel tests when running locally?
I enabled more workers to speed local testing, but we can change it back if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They were occasionally failing locally and this made them more robust.
I just went with disabling parallel tests to get it out quicker. We can test it now with multiple workers and see how well it works.
Let's merge this so CI tests complete again and make any adjustments in follow-up PRs. |
Motivation for the change, related issues
Some Playwright tests were broken by last-minute changes to #1731.
Fixes #1818
Implementation details
Testing Instructions (or ideally a Blueprint)