[Website] Bugfix: Delist data-liberation-core.phar from the preloaded offline mode assets #2072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… offline mode assets Removes data-liberation-core.phar from the list of assets preloaded to support offline mode. It was implicitly added to that list in #2058. The preloading triggers the following error: ``` Failed to execute 'addAll' on 'Cache': Cache.addAll(): duplicate requests ``` The error stops the initialization of the offline mode cache on the first page load. It still work on subsequent page loads. Still, this behavior breaks an E2E test in trunk. Playground doesn't need to preload that asset. It is only required for a psecific flavor of the importWxr step and there's already an established pattern of not preloading plugins, e.g. the SQLite database integration plugin is not preloaded. ## Testing instructions Confirm the Chromium E2E tests pass
adamziel
added
[Type] Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes data-liberation-core.phar from the list of assets preloaded to support offline mode. It was implicitly added to that list in #2058.
The preloading triggers the following error:
The error stops the initialization of the offline mode cache on the first page load. It still work on subsequent page loads. Still, this behavior breaks an E2E test in trunk.
Playground doesn't need to preload that asset. It is only required for a psecific flavor of the importWxr step and there's already an established pattern of not preloading plugins, e.g. the SQLite database integration plugin is not preloaded.
Testing instructions
Confirm the Chromium E2E tests pass