PHP: Add zif_array_filter to Asyncify list #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
added
[Type] Bug
adamziel
commented
May 20, 2023
| @@ -142,7 +142,7 @@ export class NodePHP extends BasePHP { | |||
| * | |||
| * This method can only be used when PHP was compiled with the CLI SAPI | |||
| * and it cannot be used in conjunction with `run()`. | |||
| * | |||
| * | |||
There was a problem hiding this comment.
This is weird, I don't want prettier to do that.
wojtekn
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds
zif_array_filterto Asyncify list to fix the WooCommerce error reported in #392I had no chance to test besides adding the test case and rebuilding PHP. @cpapazoglou – would you take it for a spin?
CC @danielbachhuber