PHP: Allow overwriting the quit option in emscriptenOptions #937
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR doing?
Based on the issue #926
By default, even if you add a
quit
method inemscryptenOptions
:it is overwritten by the actual one on line
57
innode-php.ts
:This PR is moving this template callback to be overwritten by
emscryptenOptions
object given by user.What problem is it solving?
To avoid throwing error from
php.exit()
even if it is exiting quietly.Testing Instructions
This should display nothing.